diff --git a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java index faee2c8..60380e6 100644 --- a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java +++ b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java @@ -13,7 +13,8 @@ public class TorpedoStore { private double FAILURE_RATE = 0.0; //NOSONAR private int torpedoCount = 0; - + + Random generator = new Random(); public TorpedoStore(int numberOfTorpedos){ this.torpedoCount = numberOfTorpedos; @@ -31,18 +32,18 @@ public TorpedoStore(int numberOfTorpedos){ public boolean fire(int numberOfTorpedos){ if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){ - new IllegalArgumentException("numberOfTorpedos"); + throw new IllegalArgumentException("numberOfTorpedos"); } boolean success = false; // simulate random overheating of the launcher bay which prevents firing - Random generator = new Random(); + double r = generator.nextDouble(); if (r >= FAILURE_RATE) { // successful firing - this.torpedoCount =- numberOfTorpedos; + this.torpedoCount -= numberOfTorpedos; success = true; } else { // simulated failure