Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Toggle silent method #27

Closed
palcarazm opened this issue Jul 7, 2022 · 2 comments · Fixed by #30
Closed

[FEATURE] Toggle silent method #27

palcarazm opened this issue Jul 7, 2022 · 2 comments · Fixed by #30
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@palcarazm
Copy link
Owner

Is your feature request related to a problem? Please describe.
Provide silent support to toggle method

Describe the solution you'd like
Such as on and off methods, provide silent support to toggle method

Describe alternatives you've considered
😞

Additional context
From gitbrent#53 by @guillaumecardon

@palcarazm palcarazm added the enhancement New feature or request label Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Hi! 👋
Thanks for your issue. You are helping to improve Bootstrap 5 toggle.

@palcarazm
Copy link
Owner Author

Hi @guillaumecardon

Do you want to send a pull request for fixing the issue in order to be correctly acknowledged?

Is just including your initial fix and runt grunt job to minify files:

Toggle.prototype.toggle = function (silent) {
    if (this.$element.prop('checked')) this.off(silent)
    else this.on(silent)
}

@palcarazm palcarazm added this to the v4.2.0 milestone Jul 7, 2022
@palcarazm palcarazm self-assigned this Jul 9, 2022
palcarazm added a commit that referenced this issue Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant