Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header params as tag values #48

Open
ellisjoe opened this issue Oct 26, 2017 · 1 comment
Open

Header params as tag values #48

ellisjoe opened this issue Oct 26, 2017 · 1 comment

Comments

@ellisjoe
Copy link
Contributor

Header params are separated by commas (https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2) which conflicts with our tagged key/value pair delimiter.
@schlosna
Copy link
Contributor

Yeah, thinking we might want to use ASCII character codes 29, 30, 31 as separators, or go full structured serDe like Jackson. Thoughts?

Will also add tests for user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schlosna @ellisjoe