Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider loosening InvocationEventHandler generic to Object #393

Open
carterkozak opened this issue Sep 9, 2019 · 0 comments
Open

Consider loosening InvocationEventHandler generic to Object #393

carterkozak opened this issue Sep 9, 2019 · 0 comments

Comments

@carterkozak
Copy link
Contributor

carterkozak commented Sep 9, 2019

What happened?

Several of our handlers require a small slice of what is available on InvocationHandler:

  • TracingInvocationEventHandler only uses java.reflect.Method.getName() for operation names
  • MetricsInvocationEventHandler uses getStartTimeNanos() and getMethod()
  • CompositeInvocationEventHandler uses no values from InvocationContnext, only a array of contexts.

What did you want to happen?

We should consider loosening InvocationEventHandler generic to Object from InvocationContext. CompositeInvocationEventHandler may implement InvocationEventHandler<Object[]> and avoid copying argument arrays, additional System.nanoTime calls, etc.

@carterkozak carterkozak changed the title Consider loosening InvocationEventHanndler generic to Object Consider loosening InvocationEventHandler generic to Object Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant