Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support undecided observability state #32

Open
carterkozak opened this issue Nov 1, 2018 · 4 comments
Open

Support undecided observability state #32

carterkozak opened this issue Nov 1, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@carterkozak
Copy link
Contributor

The default sampler should not cause a local service to observe operations, but it should also not prevent upstream tracing-aware services from recording trace data based on their local sampler configuration. This requires samplers to support an additional undecided state in addition to observed, and not observed.

In practice this should prevent the X-B3-Sampled from being set on outgoing requests.

@schlosna
Copy link
Contributor

schlosna commented Jun 7, 2019

Is this resolved by #166?

@carterkozak
Copy link
Contributor Author

Not quite yet, I think we still want to update the sampler API to produce UNDECIDED unless specifically configured. This way requests from non-configurable clients sampled at a higher rate by reconfiguring the target server. Thoughts?

@iamdanfox
Copy link
Contributor

I started implementing this, but couldn't quite figure out how a TraceSampler would ever choose between UNDECIDED and DO_NOT_SAMPLE, so put together this approach: #170

@carterkozak
Copy link
Contributor Author

I think “undecided” should be used as the default sampler (would not impact WC services)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants