Provide a clean mechanism to lock refresh tokens to sdk versions #1074
+309
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
commented
Jan 7, 2025
| $refreshTokenMarker: undefined, | ||
| }; | ||
|
|
||
| const oldLocalStorageKey = `@osdk/oauth : refresh : ${client.client_id}`; |
There was a problem hiding this comment.
Ensure that people not using this feature won't get logged out on upgrade of @osdk/oauth
packages/oauth/src/common.test.ts
Outdated
| $refreshTokenMarker: "magic_marker_friend", | ||
| }; | ||
|
|
||
| const localStorageKey = |
There was a problem hiding this comment.
Make sure that if you do specify the refreshTokenMarker that it is used.
| @@ -237,7 +243,7 @@ export function createAuthorizationServer( | |||
| | "revocation_endpoint" | |||
| > | |||
| > { | |||
| const issuer = `${new URL(ctxPath, url)}`; | |||
| const issuer = `${new URL(ctxPath, url + "/")}`; | |||
There was a problem hiding this comment.
Fix an issue where Tim's tests weren't working if you forgot trailing slash
| @@ -24,6 +24,7 @@ | |||
| "clean": "rm -rf lib dist types build tsconfig.tsbuildinfo", | |||
| "fix-lint": "eslint . --fix && dprint fmt --config $(find-up dprint.json)", | |||
| "lint": "eslint . && dprint check --config $(find-up dprint.json)", | |||
| "test": "vitest run --pool=forks", | |||
There was a problem hiding this comment.
I think Tim's changes were not properly failing build due to this not being present.
ericanderson
changed the title
ssanjay1
previously approved these changes
Jan 8, 2025
policy-bot
bot
dismissed
ssanjay1’s stale review
Invalidated by push of d717767
ericanderson
force-pushed
the
1073-tokens-with-outdated-permissions-cause-403-errors-when-user-loads-new-version-of-app-provide-way-to-get-new-token-with-new-permissions-on-load
branch
from
1c60479 to
dee814c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073
Example usage would be: