Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress or fix warnings in generated code #1635

Open
rzpt opened this issue Feb 8, 2022 · 0 comments
Open

suppress or fix warnings in generated code #1635

rzpt opened this issue Feb 8, 2022 · 0 comments

Comments

@rzpt
Copy link
Contributor

rzpt commented Feb 8, 2022

What happened?

There are warnings in eclipse on generated code.
I tried to suppress them in palantir/gradle-conjure#951 but if we can suppress them at the source, that would be great.

All methods in a class DefaultBuilder implements Builder seem to be missing @Override
These can be unused:
_plainSerDe on Async and Blocking classes.
UndertowRuntime runtime on an Endpoint.

There may be more, but I am currently working on a very small project with only these warnings.

What did you want to happen?

No warnings in eclipse on generated code.

rzpt pushed a commit that referenced this issue Nov 16, 2022
Remove @SuppressWarnings("deprecation") on deprecated methods. The
annotation is for suppressing calls of deprecated methods, not
implementation of deprecated methods.

Only generated _plainSerDe when it is used.

Fixes #1635
rzpt pushed a commit that referenced this issue Nov 18, 2022
Remove @SuppressWarnings("deprecation") on deprecated methods. The
annotation is for suppressing calls of deprecated methods, not
implementation of deprecated methods.

partial fix for #1635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant