You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unlike with other return types, conjure-go special cases binary endpoints to use the ReadCloser stream type rather than the default []byte. Specifically, endpoints that return binary use ReadCloser while optional<binary> endpoints will return *ReadCloser after the resolution of #192. In contrast endpoints with either a set<binary> or list<binary> type use an unstreamable [][]byte go type. Ultimately this might be the right choice but we should compare the implementation against conjure-java, validate that this type works, and add unit/integration testing to guarantee this behavior.
The text was updated successfully, but these errors were encountered:
I did some testing in java and found the following type conversions from conjure to java: binary -> BinaryResponseBody optional<binary> -> Optional<BinaryResponseBody> list<binary> -> List<ByteBuffer
@AdamDeHovitzList<ByteBuffer> doesn't look like streaming to me, so at first glance it looks like this is consistent with the Java implementation, but I'm not 100% sure
Unlike with other return types, conjure-go special cases
binary
endpoints to use theReadCloser
stream type rather than the default[]byte
. Specifically, endpoints that returnbinary
useReadCloser
whileoptional<binary>
endpoints will return*ReadCloser
after the resolution of #192. In contrast endpoints with either aset<binary>
orlist<binary>
type use an unstreamable[][]byte
go type. Ultimately this might be the right choice but we should compare the implementation againstconjure-java
, validate that this type works, and add unit/integration testing to guarantee this behavior.The text was updated successfully, but these errors were encountered: