Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean treeikpossolver_online #19

Open
bit-pirate opened this issue May 21, 2013 · 4 comments
Open

Clean treeikpossolver_online #19

bit-pirate opened this issue May 21, 2013 · 4 comments
Assignees

Comments

@bit-pirate
Copy link
Contributor

  • Get rid of commented out code
  • Get rid of duplicated functions (normal + *_it)
  • Discuss a patch for the KDL version
@ghost ghost assigned bit-pirate May 21, 2013
@bit-pirate
Copy link
Contributor Author

This is related to #18.

@bit-pirate
Copy link
Contributor Author

First, some information (also for myself) to shed some light on the mess inside the IK solver:

  • The *_it versions have been added, because the first version didn't do iterations.
  • A low pass filter for smoothing the joint position output has been added.
  • Some logic has been added to recognise small end effector motions, in which higher smoothing is applied (to avoid shaking of the robot due to noisy input)
    • This is probably obsolete when using Hilario's filter for the motion tracking input.
    • It's also currently deactivated (unintentionally as it looks like ...)
  • The commented-out code is the result of various tests and commiting before cleaning that up.

@bit-pirate
Copy link
Contributor Author

After spending some time getting into my own code again, I came up with this agenda to clean and simplify the IK solver:

  • Merge iterating and normal versions (i.e. normal version = iterating version with 1 iteration)
  • Remove filtering and small-motion-checking or - if really needed - move it one level higher up into the piece of code calling the ik solver (i.e. tree_kinematics.cpp)
  • Cartesian velocity limiting
    • checking one time at the start should be enough, since the largest twist occurs in the first iteration
    • move it out off the ik solver as well (i.e. into tree_kinematics.cpp)

Any objections or comments?

@adolfo-rt
Copy link
Contributor

Changes description seem sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants