From 186bd48520c441dd07a5c005ce1f9700974589ba Mon Sep 17 00:00:00 2001
From: Alessandro Gelmi <alessandro.gelmi@cinetix-team.it>
Date: Fri, 17 May 2024 13:37:29 +0200
Subject: [PATCH] chore: add traceId to SEND_TOAST_ERROR and moved
 SEND_LOGIN_METHOD after login success (#1208)

---
 .../src/pages/login/SpidSelect.tsx                   |  4 ----
 .../src/pages/success/Success.tsx                    | 12 ++++++++++--
 packages/pn-personafisica-webapp/src/App.tsx         |  2 +-
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/packages/pn-personafisica-login/src/pages/login/SpidSelect.tsx b/packages/pn-personafisica-login/src/pages/login/SpidSelect.tsx
index 7a27b8fc84..9de6dfcf0b 100644
--- a/packages/pn-personafisica-login/src/pages/login/SpidSelect.tsx
+++ b/packages/pn-personafisica-login/src/pages/login/SpidSelect.tsx
@@ -29,10 +29,6 @@ const SpidSelect = ({ onBack }: { onBack: () => void }) => {
       SPID_IDP_ID: IDP.entityId,
     });
 
-    PFLoginEventStrategyFactory.triggerEvent(PFLoginEventsType.SEND_LOGIN_METHOD, {
-      entityID: IDP.entityId,
-    });
-
     window.location.assign(
       `${URL_API_LOGIN}/login?entityID=${IDP.entityId}&authLevel=SpidL2&RelayState=send`
     );
diff --git a/packages/pn-personafisica-login/src/pages/success/Success.tsx b/packages/pn-personafisica-login/src/pages/success/Success.tsx
index 90df07121f..b4856b34f8 100644
--- a/packages/pn-personafisica-login/src/pages/success/Success.tsx
+++ b/packages/pn-personafisica-login/src/pages/success/Success.tsx
@@ -2,7 +2,9 @@ import { useCallback, useEffect, useMemo } from 'react';
 
 import { AppRouteParams, sanitizeString } from '@pagopa-pn/pn-commons';
 
+import { PFLoginEventsType } from '../../models/PFLoginEventsType';
 import { getConfiguration } from '../../services/configuration.service';
+import PFLoginEventStrategyFactory from '../../utility/MixpanelUtils/PFLoginEventStrategyFactory';
 import { storageAarOps } from '../../utility/storage';
 
 const SuccessPage = () => {
@@ -26,12 +28,18 @@ const SuccessPage = () => {
     if (redirectUrl && [PF_URL].findIndex((url) => url && redirectUrl.startsWith(url)) > -1) {
       window.location.replace(`${redirectUrl}${sanitizeString(token)}`);
     }
-
-    sessionStorage.removeItem('IDP');
   }, [aar, token]);
 
   useEffect(() => {
     calcRedirectUrl();
+
+    const IDP = sessionStorage.getItem('IDP');
+
+    PFLoginEventStrategyFactory.triggerEvent(PFLoginEventsType.SEND_LOGIN_METHOD, {
+      entityID: IDP,
+    });
+
+    sessionStorage.removeItem('IDP');
   }, []);
 
   return null;
diff --git a/packages/pn-personafisica-webapp/src/App.tsx b/packages/pn-personafisica-webapp/src/App.tsx
index ea2368e3cf..29de5e09ee 100644
--- a/packages/pn-personafisica-webapp/src/App.tsx
+++ b/packages/pn-personafisica-webapp/src/App.tsx
@@ -250,7 +250,7 @@ const App = () => {
 
     PFEventStrategyFactory.triggerEvent(PFEventsType.SEND_TOAST_ERROR, {
       reason: error.code,
-      traceid: traceId,
+      traceId,
       page_name: getCurrentEventTypePage(pathname),
       message: error.message,
       httpStatusCode: status,