fix: [IOPLT-996] Enable quick dev access in the IdentificationLockScreen with screen reader enabled
#6769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
dmnplb
changed the title
IdentificationLockScreen with screen reader enabledIdentificationLockScreen with screen reader enabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6769 +/- ##
=======================================
Coverage 51.04% 51.04%
=======================================
Files 1583 1583
Lines 32720 32720
Branches 7400 7401 +1
=======================================
Hits 16703 16703
+ Misses 15970 15959 -11
- Partials 47 58 +11
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
adelloste
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR allows quick developer access in the
IdentificationLockScreenwhen the screen reader is enabled. Previously you were forced to enter each single digit of the predefined unlock code (defaultPin), making the developer experience even more miserable.List of changes proposed in this pull request
How to test
Run the app in the local environment with VoiceOver/Talkback enabled. You should be able to access the button with the unlock icon with the screen reader.