From 97e31a4e2de6a3a6beccf763e27b1ba262a76574 Mon Sep 17 00:00:00 2001 From: Alice Di Rico <83651704+Ladirico@users.noreply.github.com> Date: Thu, 25 Jan 2024 16:48:36 +0100 Subject: [PATCH 1/6] update design-system version --- package.json | 2 +- ts/screens/onboarding/UnlockAccessScreen.tsx | 5 ++--- yarn.lock | 8 ++++---- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index 4836709eaa4..752008652f6 100644 --- a/package.json +++ b/package.json @@ -114,7 +114,7 @@ "dependencies": { "@babel/plugin-transform-regenerator": "^7.18.6", "@gorhom/bottom-sheet": "^4.1.5", - "@pagopa/io-app-design-system": "1.20.0", + "@pagopa/io-app-design-system": "1.20.1", "@pagopa/io-pagopa-commons": "^3.1.0", "@pagopa/io-react-native-crypto": "^0.2.1", "@pagopa/io-react-native-login-utils": "^0.2.2", diff --git a/ts/screens/onboarding/UnlockAccessScreen.tsx b/ts/screens/onboarding/UnlockAccessScreen.tsx index 5da1599e745..6be74c5b78a 100644 --- a/ts/screens/onboarding/UnlockAccessScreen.tsx +++ b/ts/screens/onboarding/UnlockAccessScreen.tsx @@ -9,7 +9,6 @@ import { H6, IOColors, IOStyles, - LabelSmall, Pictogram, VSpacer } from "@pagopa/io-app-design-system"; @@ -56,7 +55,7 @@ const UnlockAccessScreen = (props: Props) => { + {I18n.t("authentication.unlockmodal.listitem3_1")}{" "} {I18n.t("authentication.unlockmodal.listitem3_2")}{" "} @@ -66,7 +65,7 @@ const UnlockAccessScreen = (props: Props) => { {I18n.t("authentication.unlockmodal.listitem3_4")}{" "} {I18n.t("authentication.unlockmodal.listitem3_5")} - + } /> diff --git a/yarn.lock b/yarn.lock index a1e49c7a438..82b5e929964 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3051,10 +3051,10 @@ dependencies: "@types/node" ">= 8" -"@pagopa/io-app-design-system@1.20.0": - version "1.20.0" - resolved "https://registry.yarnpkg.com/@pagopa/io-app-design-system/-/io-app-design-system-1.20.0.tgz#d72025055360f7e8640c7a4c540835274108b626" - integrity sha512-sXe43yVbCpNrSivHgNiGis6qB4PGmP9z3ecY8A+s6jM9HowaAzgWdHb66FQwNqrxbGoJr/KbtFiSiNC3AwHAZA== +"@pagopa/io-app-design-system@1.20.1": + version "1.20.1" + resolved "https://registry.yarnpkg.com/@pagopa/io-app-design-system/-/io-app-design-system-1.20.1.tgz#e439ad96e5dc73eeece2172f5141abfbcb30558e" + integrity sha512-ClSiEj5BrJpTMfR95wrhLz9FkFmitbZivPdEj2VRgi3Xusoclv8lb2RBUQetpPsVTK0cEV4uWPlthSJG/iNbiA== dependencies: "@pagopa/ts-commons" "^12.0.0" "@testing-library/jest-native" "^5.4.2" From 3268d41c28016bd882c4f8913df18151e8d6f471 Mon Sep 17 00:00:00 2001 From: Alice Di Rico <83651704+Ladirico@users.noreply.github.com> Date: Thu, 25 Jan 2024 17:57:16 +0100 Subject: [PATCH 2/6] change dimention to show/not show the icon and delete a dot into the copy --- locales/en/index.yml | 2 +- locales/it/index.yml | 2 +- ts/screens/authentication/NewOptInScreen.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/locales/en/index.yml b/locales/en/index.yml index e0e59a0642b..ba1d3ff1414 100644 --- a/locales/en/index.yml +++ b/locales/en/index.yml @@ -684,7 +684,7 @@ authentication: identity_check: You’ll no longer have to authenticate with SPID or CIE every 30 days, but only once a year or if you log out. security_suggests: Safety tips passcode: Any other time, you’ll just need your fingerprint, face recognition or unlock code. - notification: Whenever there is a new authentication to IO, we'll send you an email to let you know. If it’s not you, you can remotely lock access to the app. + notification: Whenever there is a new authentication to IO, we'll send you an email to let you know. If it’s not you, you can remotely lock access to the app button_accept_lv: Continue with quick access button_decline_lv: Authenticate with SPID or CIE every 30 days security_suggestions: diff --git a/locales/it/index.yml b/locales/it/index.yml index f5a8d5b56b3..cc3a2326a7d 100644 --- a/locales/it/index.yml +++ b/locales/it/index.yml @@ -684,7 +684,7 @@ authentication: identity_check: Non dovrai più autenticarti con SPID o CIE ogni 30 giorni, ma solo una volta all’anno o se esci dall’app security_suggests: Alcuni consigli di sicurezza passcode: Per tutte le altre volte basterà il tuo volto, impronta o codice di sblocco - notification: Riceverai un’email a ogni nuovo accesso. Se non lo riconosci, potrai bloccare l’accesso a IO. + notification: Riceverai un’email a ogni nuovo accesso. Se non lo riconosci, potrai bloccare l’accesso a IO button_accept_lv: Continua con l’accesso rapido button_decline_lv: Autenticati con SPID o CIE ogni 30 giorni security_suggestions: diff --git a/ts/screens/authentication/NewOptInScreen.tsx b/ts/screens/authentication/NewOptInScreen.tsx index 83fc492484e..a1fdadf06e9 100644 --- a/ts/screens/authentication/NewOptInScreen.tsx +++ b/ts/screens/authentication/NewOptInScreen.tsx @@ -98,7 +98,7 @@ const NewOptInScreen = (props: Props) => { }} > - {Dimensions.get("screen").height > 780 && ( + {Dimensions.get("screen").height > 820 && ( From c2606536a6a345ad1dfd52bc918dd14073f94a11 Mon Sep 17 00:00:00 2001 From: Alice Di Rico <83651704+Ladirico@users.noreply.github.com> Date: Tue, 30 Jan 2024 11:41:19 +0100 Subject: [PATCH 3/6] change value with reusable const --- ts/screens/authentication/NewOptInScreen.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ts/screens/authentication/NewOptInScreen.tsx b/ts/screens/authentication/NewOptInScreen.tsx index a1fdadf06e9..f7ee3471792 100644 --- a/ts/screens/authentication/NewOptInScreen.tsx +++ b/ts/screens/authentication/NewOptInScreen.tsx @@ -35,6 +35,8 @@ const contextualHelpMarkdown: ContextualHelpPropsMarkdown = { body: "authentication.opt_in.contextualHelpContent" }; +export const MIN_HEIGHT_TO_SHOW_FULL_RENDER = 820; + export type ChosenIdentifier = { identifier: "SPID" | "CIE"; }; @@ -98,7 +100,7 @@ const NewOptInScreen = (props: Props) => { }} > - {Dimensions.get("screen").height > 820 && ( + {Dimensions.get("screen").height > MIN_HEIGHT_TO_SHOW_FULL_RENDER && ( From 325f83235a4c90c514420a02ad8b903a68ca5878 Mon Sep 17 00:00:00 2001 From: Alice Di Rico <83651704+Ladirico@users.noreply.github.com> Date: Tue, 30 Jan 2024 17:32:50 +0100 Subject: [PATCH 4/6] fix text for opt-in screen --- locales/en/index.yml | 2 +- locales/it/index.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/locales/en/index.yml b/locales/en/index.yml index 17d7309ca65..af8bb098749 100644 --- a/locales/en/index.yml +++ b/locales/en/index.yml @@ -686,7 +686,7 @@ authentication: passcode: Any other time, you’ll just need your fingerprint, face recognition or unlock code. notification: Whenever there is a new authentication to IO, we'll send you an email to let you know. If it’s not you, you can remotely lock access to the app button_accept_lv: Continue with quick access - button_decline_lv: Authenticate with SPID or CIE every 30 days + button_decline_lv: Log in with SPID or CIE every 30 days security_suggestions: fingerprint: Do not share your unlock code or biometric recognition with anyone. io_logout: If you lose your device, log out from the web. diff --git a/locales/it/index.yml b/locales/it/index.yml index 10d9cd06804..6db3877713e 100644 --- a/locales/it/index.yml +++ b/locales/it/index.yml @@ -686,7 +686,7 @@ authentication: passcode: Per tutte le altre volte basterà il tuo volto, impronta o codice di sblocco notification: Riceverai un’email a ogni nuovo accesso. Se non lo riconosci, potrai bloccare l’accesso a IO button_accept_lv: Continua con l’accesso rapido - button_decline_lv: Autenticati con SPID o CIE ogni 30 giorni + button_decline_lv: Entra con SPID o CIE ogni 30 giorni security_suggestions: fingerprint: Non condividere il tuo codice di sblocco o riconoscimento biometrico con nessuno io_logout: Se perdi il dispositivo, esci dall’app da web From 1c5966b0f16e9f0c5e563a34847c1ac59aecf869 Mon Sep 17 00:00:00 2001 From: Alice Di Rico <83651704+Ladirico@users.noreply.github.com> Date: Wed, 31 Jan 2024 14:24:59 +0100 Subject: [PATCH 5/6] change text of first feature info of opt_in screen --- locales/en/index.yml | 2 +- locales/it/index.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/locales/en/index.yml b/locales/en/index.yml index af8bb098749..396efbffb21 100644 --- a/locales/en/index.yml +++ b/locales/en/index.yml @@ -681,7 +681,7 @@ authentication: contextualHelpContent: Here you can find information on how to authenticate on IO and some security tips. news: News title: It is now easier to access! - identity_check: You’ll no longer have to authenticate with SPID or CIE every 30 days, but only once a year or if you log out. + identity_check: You’ll no longer have to identify yourself with SPID or CIE every 30 days, but only once a year or if you log out. security_suggests: Safety tips passcode: Any other time, you’ll just need your fingerprint, face recognition or unlock code. notification: Whenever there is a new authentication to IO, we'll send you an email to let you know. If it’s not you, you can remotely lock access to the app diff --git a/locales/it/index.yml b/locales/it/index.yml index 6db3877713e..ea2e411035a 100644 --- a/locales/it/index.yml +++ b/locales/it/index.yml @@ -681,7 +681,7 @@ authentication: contextualHelpContent: Qui puoi trovare le informazioni sulle modalità di autenticazione su IO e alcuni consigli di sicurezza. news: novità title: Ora è più facile accedere! - identity_check: Non dovrai più autenticarti con SPID o CIE ogni 30 giorni, ma solo una volta all’anno o se esci dall’app + identity_check: Non dovrai più identificarti con SPID o CIE ogni 30 giorni, ma solo una volta all’anno o se esci dall’app security_suggests: Alcuni consigli di sicurezza passcode: Per tutte le altre volte basterà il tuo volto, impronta o codice di sblocco notification: Riceverai un’email a ogni nuovo accesso. Se non lo riconosci, potrai bloccare l’accesso a IO From a73be1285a6f4b9c8df4e0b24d90146ae7be366b Mon Sep 17 00:00:00 2001 From: Alice Di Rico <83651704+Ladirico@users.noreply.github.com> Date: Wed, 31 Jan 2024 14:50:04 +0100 Subject: [PATCH 6/6] add comment to explain the logic of show or not show the pictogram --- ts/screens/authentication/NewOptInScreen.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ts/screens/authentication/NewOptInScreen.tsx b/ts/screens/authentication/NewOptInScreen.tsx index f7ee3471792..5c088079a8f 100644 --- a/ts/screens/authentication/NewOptInScreen.tsx +++ b/ts/screens/authentication/NewOptInScreen.tsx @@ -100,6 +100,10 @@ const NewOptInScreen = (props: Props) => { }} > + {/* + if the device height is > 820 then the pictogram will be visible, + otherwise it will not be visible + */} {Dimensions.get("screen").height > MIN_HEIGHT_TO_SHOW_FULL_RENDER && (