Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOPLT-989] Add proper configuration of threshold value to the ForceScrollDownView component #6787

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Mar 5, 2025

Short description

This PR updates the configuration of the ForceScrollDownView component by setting the threshold prop to the correct value. The previous values were hard-coded and not linked to the measures of the FooterActions component.

List of changes proposed in this pull request

  • Add a dynamic value to the threshold by taking the values from the useFooterActionsInlineMeasurements hook

How to test

Before testing, make sure that io-app-design-system in the package.json points to the update in the PR #423. Then, go to the one of the screens edited in this PR and check the behavior in different device screen sizes

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Mar 5, 2025
@dmnplb dmnplb self-assigned this Mar 5, 2025
@dmnplb dmnplb requested review from ChrisMattew, gispada, freddi301 and a team as code owners March 5, 2025 15:54
Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.96%. Comparing base (f591e0a) to head (b2b9d06).

Files with missing lines Patch % Lines
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 0.00% 1 Missing ⚠️
...pay/onboarding/screens/InitiativeDetailsScreen.tsx 0.00% 1 Missing ⚠️
...nce/screens/ItwIssuanceCredentialPreviewScreen.tsx 0.00% 1 Missing ⚠️
...screens/ItwIssuanceCredentialTrustIssuerScreen.tsx 0.00% 1 Missing ⚠️
...t/issuance/screens/ItwIssuanceEidPreviewScreen.tsx 0.00% 1 Missing ⚠️
...remote/screens/ItwRemoteClaimsDisclosureScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6787      +/-   ##
==========================================
+ Coverage   46.40%   50.96%   +4.55%     
==========================================
  Files        1453     1578     +125     
  Lines       30546    32694    +2148     
  Branches     6913     7409     +496     
==========================================
+ Hits        14176    16663    +2487     
+ Misses      16320    15972     -348     
- Partials       50       59       +9     
Files with missing lines Coverage Δ
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 8.57% <0.00%> (-0.26%) ⬇️
...pay/onboarding/screens/InitiativeDetailsScreen.tsx 9.52% <0.00%> (-0.48%) ⬇️
...nce/screens/ItwIssuanceCredentialPreviewScreen.tsx 9.09% <0.00%> (-0.29%) ⬇️
...screens/ItwIssuanceCredentialTrustIssuerScreen.tsx 36.36% <0.00%> (-1.14%) ⬇️
...t/issuance/screens/ItwIssuanceEidPreviewScreen.tsx 8.57% <0.00%> (-0.26%) ⬇️
...remote/screens/ItwRemoteClaimsDisclosureScreen.tsx 17.64% <0.00%> (-0.54%) ⬇️

... and 312 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f591e0a...b2b9d06. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant