Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPLT-989] Remove local ForceScrollDownView from the codebase #6784

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Mar 5, 2025

Short description

This PR removes the local ForceScrollDownView from the codebase to avoid accidental import.

List of changes proposed in this pull request

  • Remove the local instance
  • Update the InitiativeDetailsScreen screen (IDPay flow) to use the component from the DS, instead of using the local one

How to test

N/A

@dmnplb dmnplb added the 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed label Mar 5, 2025
@dmnplb dmnplb requested review from ChrisMattew, gispada, freddi301 and a team as code owners March 5, 2025 09:06
Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.69%. Comparing base (f66da68) to head (117bc42).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6784      +/-   ##
==========================================
- Coverage   50.99%   48.69%   -2.30%     
==========================================
  Files        1579     1461     -118     
  Lines       32706    30781    -1925     
  Branches     7361     6931     -430     
==========================================
- Hits        16679    14990    -1689     
+ Misses      15982    15754     -228     
+ Partials       45       37       -8     
Files with missing lines Coverage Δ
...pay/onboarding/screens/InitiativeDetailsScreen.tsx 10.00% <ø> (ø)

... and 240 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f6a9b...117bc42. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb added this pull request to the merge queue Mar 5, 2025
Merged via the queue into master with commit 087c872 Mar 5, 2025
22 checks passed
@dmnplb dmnplb deleted the IOPLT-989-remove-local-force-scroll-down branch March 5, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants