Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-1238] a11y label to the ReceiptListItemTransaction component #6780

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Mar 4, 2025

Short description

This PR fixes the accessibility text on the list item transaction component, before this fix, the text was read twice.

List of changes proposed in this pull request

  • Added the accessibilityLabel to the ListItemTransaction
  • Edited the amountAccessibilityLabel with the correct value string

How to test

Inside the payments screen, with the screen reader enabled, check that the transaction list is announced once with the correct displayed data.

Preview

Before After
before.webm
after.webm

@Hantex9 Hantex9 added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Mar 4, 2025
@Hantex9 Hantex9 requested review from ChrisMattew, gispada, freddi301 and a team as code owners March 4, 2025 11:27
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Mar 4, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.81%. Comparing base (191a24e) to head (9bae654).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...receipts/components/ReceiptListItemTransaction.tsx 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (191a24e) and HEAD (9bae654). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (191a24e) HEAD (9bae654)
10 3
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6780       +/-   ##
===========================================
- Coverage   51.09%   29.81%   -21.28%     
===========================================
  Files        1581     1549       -32     
  Lines       32707    32240      -467     
  Branches     7363     7237      -126     
===========================================
- Hits        16711     9612     -7099     
- Misses      15950    22598     +6648     
+ Partials       46       30       -16     
Files with missing lines Coverage Δ
...receipts/components/ReceiptListItemTransaction.tsx 4.00% <0.00%> (-69.92%) ⬇️

... and 544 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a0037...9bae654. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant