-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [IOBP-1238] a11y label to the ReceiptListItemTransaction component #6780
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6780 +/- ##
===========================================
- Coverage 51.09% 29.81% -21.28%
===========================================
Files 1581 1549 -32
Lines 32707 32240 -467
Branches 7363 7237 -126
===========================================
- Hits 16711 9612 -7099
- Misses 15950 22598 +6648
+ Partials 46 30 -16
... and 544 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Short description
This PR fixes the accessibility text on the list item transaction component, before this fix, the text was read twice.
List of changes proposed in this pull request
accessibilityLabel
to theListItemTransaction
amountAccessibilityLabel
with the correct value stringHow to test
Inside the payments screen, with the screen reader enabled, check that the transaction list is announced once with the correct displayed data.
Preview
before.webm
after.webm