Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPLT-998] Remove legacy components from the codebase #6777

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Mar 4, 2025

Short description

This PR removes some legacy components that are no longer referenced.

List of changes proposed in this pull request

  • Remove OrderOption and ListItemComponent
  • Remove DSLegacyListItems from the Design System
  • Remove TopScreenComponent
  • Remove SearchButton
    • Slightly refactor the legacy BaseHeader to not render the component

How to test

N/A

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed labels Mar 4, 2025
@dmnplb dmnplb self-assigned this Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Mar 4, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.07%. Comparing base (f66da68) to head (e700ac7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/components/screens/BaseHeader.tsx 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6777      +/-   ##
==========================================
+ Coverage   50.99%   51.07%   +0.08%     
==========================================
  Files        1579     1575       -4     
  Lines       32706    32624      -82     
  Branches     7361     7327      -34     
==========================================
- Hits        16679    16664      -15     
+ Misses      15982    15915      -67     
  Partials       45       45              
Files with missing lines Coverage Δ
...s/components/screens/BaseScreenComponent/index.tsx 62.96% <ø> (ø)
ts/features/design-system/navigation/navigator.tsx 13.63% <ø> (ø)
ts/features/design-system/navigation/routes.ts 100.00% <ø> (ø)
ts/components/screens/BaseHeader.tsx 73.58% <75.00%> (-0.29%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f6a9b...e700ac7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant