Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [PE-998,PE-999,PE-1000,PE-1001] CGN list item a11y #6773

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request includes updates to improve CGN list item accessibility

List of changes proposed in this pull request

  • Updated @pagopa/io-app-design-system from version 5.0.3 to 5.0.4
  • Added accessibility labels to category and merchants items and badges to improve screen reader support

How to test

  • Using a real device 📱
  • Go inside CGN opportunities screen
  • Turn on the TalkBack accessibility tool
  • Try to tap/swipe on some element of category/merchants tabs
  • Ensure that the screen is reading correctly the item and the badge is not reachable with the swipe

@LeleDallas LeleDallas added a11y Activities related to accessibility Carta Giovani Nazionale IO-Bonus e pagamenti IO - Bonus e pagamenti labels Mar 3, 2025
@LeleDallas LeleDallas self-assigned this Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Mar 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 50.96%. Comparing base (f591e0a) to head (2a580d9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/cgn/screens/merchants/CgnMerchantsListScreen.tsx 7.69% 12 Missing ⚠️
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6773      +/-   ##
==========================================
+ Coverage   46.40%   50.96%   +4.55%     
==========================================
  Files        1453     1578     +125     
  Lines       30546    32697    +2151     
  Branches     6913     7367     +454     
==========================================
+ Hits        14176    16663    +2487     
+ Misses      16320    15988     -332     
+ Partials       50       46       -4     
Files with missing lines Coverage Δ
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 53.84% <0.00%> (-6.16%) ⬇️
...s/cgn/screens/merchants/CgnMerchantsListScreen.tsx 54.83% <7.69%> (-10.55%) ⬇️

... and 324 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e3fed...2a580d9. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility Carta Giovani Nazionale IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants