Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-1231] Removed total amount from IdPayCard if reward type is EXPENSE #6771

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Mar 3, 2025

Short description

This PR removes the total amount label from the IdPayCard shown in the wallet home screen if the IdPay initiative is of the EXPENSE type.

List of changes proposed in this pull request

  • Updated the IDPay openAPI version;
  • Added a conditional render inside the IdPayCard to show the total amount;

How to test

With the dev-server started, onboard a new IDPay EXPENSE type and check that you don't see the total amount inside the wallet home page.

@Hantex9 Hantex9 added IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti labels Mar 3, 2025
@Hantex9 Hantex9 requested review from ChrisMattew, gispada, freddi301 and a team as code owners March 3, 2025 09:51
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Mar 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.09%. Comparing base (085181b) to head (e47f1e2).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6771   +/-   ##
=======================================
  Coverage   51.08%   51.09%           
=======================================
  Files        1581     1581           
  Lines       32701    32707    +6     
  Branches     7359     7362    +3     
=======================================
+ Hits        16705    16711    +6     
  Misses      15950    15950           
  Partials       46       46           
Files with missing lines Coverage Δ
ts/features/idpay/wallet/components/IdPayCard.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085181b...e47f1e2. Read the comment docs.

@Hantex9 Hantex9 added this pull request to the merge queue Mar 3, 2025
Merged via the queue into master with commit 191a24e Mar 3, 2025
22 checks passed
@Hantex9 Hantex9 deleted the IOBP-1231-remove-total-amount-on-idpay-expense-card branch March 3, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants