Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:[IOPLT-978] Changes the Sentry integration for performance monitoring #6741

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR changes the integration of Sentry SDK to remove navigation instrumentation and handle the base ReactNative one.

How to test

Check Sentry events

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.30%. Comparing base (6d90444) to head (ebe52ba).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6741   +/-   ##
=======================================
  Coverage   50.30%   50.30%           
=======================================
  Files        1563     1563           
  Lines       32510    32510           
  Branches     7350     7349    -1     
=======================================
  Hits        16353    16353           
+ Misses      16117    16105   -12     
- Partials       40       52   +12     
Files with missing lines Coverage Δ
ts/navigation/AppStackNavigator.tsx 41.30% <ø> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d90444...ebe52ba. Read the comment docs.

@CrisTofani
Copy link
Contributor Author

@shadowsheep1 Fixed all the references

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisTofani CrisTofani added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 49e4950 Feb 21, 2025
23 checks passed
@CrisTofani CrisTofani deleted the IOPLT-978 branch February 21, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants