Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPLT-959] Implements the Offline check loop feature #6734

Merged
merged 16 commits into from
Feb 24, 2025

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Feb 19, 2025

Warning

This PR depends on pagopa/io-backend#1184

Short description

This PR represents a first implementation of an infinite checker through app session of its own connectivity status.
The Code is based on @react-native-community/netinfo library, checking the connectivity on a specific endpoint exposed by our backend infrastructure. The checker runs in a specific loop handled by a saga that starts at the app opening such as the one reloading the app remote configuration. At any check it writes up the result of the check on the redux store in order to be read by any component of the app itself.

List of changes proposed in this pull request

  • implemented saga and store feature for connectivity check.

How to test

Open the app and check the saga invoke on the determined time loop.

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.31%. Comparing base (a80ec32) to head (85955a0).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/connectivity/store/reducers/index.ts 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6734      +/-   ##
==========================================
+ Coverage   50.30%   50.31%   +0.01%     
==========================================
  Files        1564     1566       +2     
  Lines       32523    32534      +11     
  Branches     7355     7311      -44     
==========================================
+ Hits        16362    16371       +9     
- Misses      16108    16122      +14     
+ Partials       53       41      -12     
Files with missing lines Coverage Δ
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
ts/features/connectivity/store/actions/index.ts 100.00% <100.00%> (ø)
ts/features/connectivity/store/reducers/index.ts 77.77% <77.77%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80ec32...85955a0. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants