-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [IOPAE-1795] Use IOScrollView
in Service details screen
#6731
refactor: [IOPAE-1795] Use IOScrollView
in Service details screen
#6731
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
@adelloste Does this PR also fix the issue of the CTA with a white block underneath in the dark mode version, isn't it? If so, I'd add the |
Yes, absolutely. Added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, great job! In terms of the UI, it's a noticeable improvement over the previous one.
Just take a look at the pressed state of the ListItem…
components. If you want to restore the previous behavior you can restore the IOStyles…
style applied to the contentContainerStyle
and apply includeContentMargins={false}
to the IOScrollView
. This last prop is essential to ensure a proper rendering.
list-item-pressed-state-services.mp4
Let me know if it's enough to fix it :)
(And again, good job!)
Good catch! Applied 3bfd7be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR updates the service details screen to use the
IOScrollView
component.List of changes proposed in this pull request
ServiceDetailsScreen
componentuseServicePreferenceByChannel
to retrieve the status of the preference by channelServiceSpecialAction
componentCgnServiceCTA
componentuseSpecialCtaCgn
to compute the primary actionPnServiceCt
a componentuseSpecialCtaPn
to compute the primary actionHow to test
Verify that the CTAs in the service details screen are rendered correctly: