Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-1191] Add a11y description to button inside the barcode scan screen #6729

Merged

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Feb 18, 2025

Short description

This PR adds a more detailed description for the buttons inside the barcode scan screen.

List of changes proposed in this pull request

  • Edited the a11y description text.

How to test

With a real device, enable the screen reader/voice over and open the barcode scan screen from the "Payments" section and check that the described text is more detailed.

@Hantex9 Hantex9 added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.27%. Comparing base (a676e00) to head (07a167e).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6729   +/-   ##
=======================================
  Coverage   50.27%   50.27%           
=======================================
  Files        1558     1558           
  Lines       32479    32479           
  Branches     7310     7364   +54     
=======================================
  Hits        16329    16329           
+ Misses      16109    16097   -12     
- Partials       41       53   +12     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a676e00...07a167e. Read the comment docs.

@Hantex9 Hantex9 added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit 5f92407 Feb 18, 2025
22 checks passed
@Hantex9 Hantex9 deleted the IOBP-1191-add-accessible-description-to-scan-screen-tab branch February 18, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants