Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPX-476] Change StatusBar style according to the current color scheme #6680

Merged
merged 47 commits into from
Feb 28, 2025

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Feb 3, 2025

Short description

This PR adds a StatusBar that changes its style according to the color scheme of the app.

List of changes proposed in this pull request

  • Add a StatusBar with a specific color scheme condition in the AppStackNavigator

Preview

Note

Please focus on the statusbar on the top while playing the videos

Before After
sb-darkmode-before.mp4
sb-darkmode-after.mp4

How to test

Change the color scheme of your app from Dev Settings and randomly check the headers of the screens. Focus your attention on the screens with an existing specific StatusBar behavior.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Feb 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.09%. Comparing base (a49b20e) to head (feedd02).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/design-system/DesignSystem.tsx 0.00% 3 Missing ⚠️
...es/design-system/components/DesignSystemScreen.tsx 0.00% 3 Missing ⚠️
...n/screens/merchants/CgnMerchantsListByCategory.tsx 0.00% 2 Missing ⚠️
.../components/BonusCard/BonusCardScreenComponent.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6680      +/-   ##
==========================================
+ Coverage   51.04%   51.09%   +0.04%     
==========================================
  Files        1583     1583              
  Lines       32720    32710      -10     
  Branches     7400     7406       +6     
==========================================
+ Hits        16703    16712       +9     
+ Misses      15970    15940      -30     
- Partials       47       58      +11     
Files with missing lines Coverage Δ
ts/components/ui/AppHeader.tsx 100.00% <ø> (ø)
ts/components/ui/FocusAwareStatusBar.tsx 100.00% <100.00%> (ø)
...nus/cgn/components/merchants/ModuleCgnDiscount.tsx 94.44% <ø> (ø)
...omponents/merchants/discount/CgnDiscountHeader.tsx 100.00% <ø> (ø)
ts/features/bonus/cgn/screens/CgnDetailScreen.tsx 4.83% <ø> (ø)
...s/cgn/screens/discount/CgnDiscountDetailScreen.tsx 69.30% <ø> (ø)
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 60.00% <100.00%> (+1.17%) ⬆️
ts/features/bonus/cgn/utils/filters.ts 100.00% <ø> (ø)
...eatures/design-system/core/DSDynamicBackground.tsx 17.64% <ø> (ø)
ts/features/fci/components/ErrorComponent.tsx 70.00% <ø> (ø)
... and 7 more

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49b20e...feedd02. Read the comment docs.

@dmnplb dmnplb added this pull request to the merge queue Feb 28, 2025
Merged via the queue into master with commit 04d2853 Feb 28, 2025
22 checks passed
@dmnplb dmnplb deleted the IOAPPX-476-adapt-status-bar-according-to-color-scheme branch February 28, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants