From d69c97f7e63ef1a4305546384d751dd2093567b8 Mon Sep 17 00:00:00 2001 From: marcobottaro <39835990+marcobottaro@users.noreply.github.com> Date: Wed, 8 Jan 2025 10:32:53 +0100 Subject: [PATCH] [DEV-2070] Rename "version" to "subpath" in UrlReplaceMapCodec (#1279) * Rename "version" to "subPath" in UrlReplaceMapCodec * Fix changeset * Fix mocked Strapi response in urlReplaceMap's test --- .changeset/tall-boxes-lay.md | 5 +++++ .../src/lib/strapi/__tests__/urlReplaceMap.test.ts | 2 +- .../src/lib/strapi/codecs/UrlReplaceMapCodec.ts | 2 +- .../src/lib/strapi/makeProps/makeUrlReplaceMap.ts | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/tall-boxes-lay.md diff --git a/.changeset/tall-boxes-lay.md b/.changeset/tall-boxes-lay.md new file mode 100644 index 0000000000..c509317502 --- /dev/null +++ b/.changeset/tall-boxes-lay.md @@ -0,0 +1,5 @@ +--- +"nextjs-website": patch +--- + +Rename "version" to "subPath" in UrlReplaceMapCodec diff --git a/apps/nextjs-website/src/lib/strapi/__tests__/urlReplaceMap.test.ts b/apps/nextjs-website/src/lib/strapi/__tests__/urlReplaceMap.test.ts index 105f35cc98..730f8f8a4c 100644 --- a/apps/nextjs-website/src/lib/strapi/__tests__/urlReplaceMap.test.ts +++ b/apps/nextjs-website/src/lib/strapi/__tests__/urlReplaceMap.test.ts @@ -16,7 +16,7 @@ const strapiResponse = { { id: 1, url: 'aaaa', - version: '2', + subPath: '2', guide: { data: { id: 1, diff --git a/apps/nextjs-website/src/lib/strapi/codecs/UrlReplaceMapCodec.ts b/apps/nextjs-website/src/lib/strapi/codecs/UrlReplaceMapCodec.ts index 705a42a574..c50c01743f 100644 --- a/apps/nextjs-website/src/lib/strapi/codecs/UrlReplaceMapCodec.ts +++ b/apps/nextjs-website/src/lib/strapi/codecs/UrlReplaceMapCodec.ts @@ -5,7 +5,7 @@ import { NullToUndefinedCodec } from './NullToUndefinedCodec'; const UrlToGuideCodec = t.strict({ id: t.number, url: t.string, - version: t.union([NullToUndefinedCodec, t.string]), + subPath: t.union([NullToUndefinedCodec, t.string]), guide: t.strict({ data: t.union([NullToUndefinedCodec, GuideCodec]), }), diff --git a/apps/nextjs-website/src/lib/strapi/makeProps/makeUrlReplaceMap.ts b/apps/nextjs-website/src/lib/strapi/makeProps/makeUrlReplaceMap.ts index fdeb5bdce8..476633a667 100644 --- a/apps/nextjs-website/src/lib/strapi/makeProps/makeUrlReplaceMap.ts +++ b/apps/nextjs-website/src/lib/strapi/makeProps/makeUrlReplaceMap.ts @@ -11,7 +11,7 @@ export function makeUrlReplaceMap( [obj.url]: `/${ obj.guide.data?.attributes.product.data.attributes.slug }/guides/${obj.guide.data?.attributes.slug}${ - obj.version ? `/${obj.version}` : '' + obj.subPath ? `/${obj.subPath}` : '' }`, }; }, {} as UrlReplaceMap);