Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Per-Repository Authentication Settings #330

Open
LucasMrqes opened this issue Sep 17, 2024 · 0 comments · May be fixed by #413
Open

Support Per-Repository Authentication Settings #330

LucasMrqes opened this issue Sep 17, 2024 · 0 comments · May be fixed by #413
Assignees
Labels
enhancement New feature or request

Comments

@LucasMrqes
Copy link
Collaborator

LucasMrqes commented Sep 17, 2024

Currently, the controller uses a single set of credentials for all GitHub or GitLab repositories it interacts with. This approach poses challenges when dealing with multiple GitHub/GitLab organizations or several GitLab projects that require distinct tokens.
This is not a problem for planning/applying layers, since the git authentication is passed to the runner distinctly ; this is a problem for adding comments to MR / PR.

The controller should use a default token, but could eventually use one specified within the TerraformRepository specification (with a reference to a Kubernetes secret or specify a token directly)

To go further: the issue is the same for the webhook token, however a workaround is to always use the same (not ideal)

@LucasMrqes LucasMrqes added the enhancement New feature or request label Sep 17, 2024
@LucasMrqes LucasMrqes changed the title Support Per-Repository Authentication Tokens Support Per-Repository Webhook Tokens Sep 17, 2024
@LucasMrqes LucasMrqes changed the title Support Per-Repository Webhook Tokens Support Per-Repository Authentication Settings Sep 17, 2024
@LucasMrqes LucasMrqes self-assigned this Nov 29, 2024
@LucasMrqes LucasMrqes linked a pull request Nov 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant