Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/Log.h conditionally available on Android #7

Open
paddybyers opened this issue Oct 19, 2011 · 1 comment
Open

utils/Log.h conditionally available on Android #7

paddybyers opened this issue Oct 19, 2011 · 1 comment

Comments

@paddybyers
Copy link
Owner

deps/v8/src/platform-posix.cc contains a dependency on <utils/Log.h>

This is available in the Android open source project (AOSP) but not in the NDK. For an NDK build, there needs to be a way to remove the dependency.

Current workaround is to have an Android-specific condition indicating whether or not the private AOSP includes are available:

a427c81

@paddybyers
Copy link
Owner Author

There's a slightly different issue on master. The newer v8 already has a conditional V8_ANDROID_LOG_STDOUT but it forgets to make the include itself conditional on that.

Fix is here:

622f690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant