Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding http_matcher.feature v3 compatibility test #751

Merged

Conversation

valkolovos
Copy link
Contributor

✈️ Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

📝 Summary

Adding a v3 compatibility test for the http_matching feature. This seemed like an easy add since there were no code changes outside of testing code required.

🔥 Motivation

Since I want to work on V3 matchers, my motivation was to learn a little more about how matchers work and move the overall V3 compatibility forward.

@valkolovos valkolovos force-pushed the http_matcher_compatibility_test branch from 7976afa to 18a65e1 Compare August 3, 2024 14:15
@JP-Ellis JP-Ellis force-pushed the http_matcher_compatibility_test branch from 18a65e1 to c6f0358 Compare August 12, 2024 06:14
@JP-Ellis JP-Ellis linked an issue Aug 12, 2024 that may be closed by this pull request
@JP-Ellis JP-Ellis enabled auto-merge (rebase) August 12, 2024 06:15
@JP-Ellis JP-Ellis merged commit 72ff0d5 into pact-foundation:master Aug 12, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3/http_matching.feature
2 participants