Automatic Releases #567
Merged
Automatic Releases #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work homie, will take a look in the morning |
In anticipation of generating changelogs from conventional commits, this contains a minor change to the formatting of older log entries, and rewrites the changelog for the most recent release to make usre of the new format. Signed-off-by: JP-Ellis <[email protected]>
This PR significant changes the release process, by mostly automating it all. The docs on creating releases has been updated and moved into the `docs/` folder (anticipating that we will use MkDocs eventually). The check step in the build pipeline has been removed, as it is redundant given that cibuildwheel already does checks. Signed-off-by: JP-Ellis <[email protected]>
As the `pact.v3` module is still a work in progress, importing it raises a warning. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/automatic-release
branch
from
e9f67f1
to
d9c27c3
Compare
JP-Ellis
added a commit
that referenced
this pull request
Mar 5, 2024
The cibuildwheel process does a check that the wheels are valid, and also performs an installation of the wheel and a basic check that the import is working fine. It seems redundant to be doing a separate check. This was intended in commit 9604839, but a rebase inadvertently re-intruced the check. Ref: 02eab542cc667ac3d19bd6acaf0d7a4a0 Ref: #567 Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
added a commit
that referenced
this pull request
Mar 5, 2024
The cibuildwheel process does a check that the wheels are valid, and also performs an installation of the wheel and a basic check that the import is working fine. It seems redundant to be doing a separate check. This was intended in commit 9604839, but a rebase inadvertently re-intruced the check. Ref: 02eab542cc667ac3d19bd6acaf0d7a4a0 Ref: #567 Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
added a commit
that referenced
this pull request
Mar 5, 2024
For some reason, the rebase done as part of #567 really did not go well, and some entire steps were inadvertently replaced. It is my bad, and here's another (and hopefully final) fix. Ref: #567 Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
added a commit
that referenced
this pull request
Mar 5, 2024
For some reason, the rebase done as part of #567 really did not go well, and some entire steps were inadvertently replaced. It is my bad, and here's another (and hopefully final) fix. Ref: #567 Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
added a commit
that referenced
this pull request
Mar 5, 2024
For some reason, the rebase done as part of #567 really did not go well, and some entire steps were inadvertently replaced. It is my bad, and here's another (and hopefully final) fix. Ref: #567 Signed-off-by: JP-Ellis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Automate the release process 🤖
While uploading wheels to PyPI was already automated, this PR further automates:
masterThis does require a GitHub Personal Access Token (which I have created and added to the
pypienvironment).From now on, the only manual step to create a new release should be pushing a new git tag 🥳
🚨 Breaking Changes🔥 Motivation
Who doesn't want automation?
🔨 Test Plan
This was tested over in my fork. Specifically:
The run was slightly modified to ensure it runs faster by targeting only
cp312-*andx86_64platforms, but otherwise should be all good.🔗 Related issues/PRs