Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structured Mismatch class #644

Closed
1 of 2 tasks
JP-Ellis opened this issue Apr 2, 2024 · 1 comment · Fixed by #815
Closed
1 of 2 tasks

Add structured Mismatch class #644

JP-Ellis opened this issue Apr 2, 2024 · 1 comment · Fixed by #815
Assignees
Labels
area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase smartbear-supported This issue is supported by SmartBear type:feature New feature

Comments

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Apr 2, 2024

Have you read the Contributing Guidelines on issues?

Description

Replace the generic dict[str, Any] returned by a mismatch with a more informative class:

@property
def mismatches(self) -> list[dict[str, Any]]:
"""
Mismatches between the Pact and the server.
"""
return self._mismatches

Has this been requested on Canny?

No response

Motivation

A new class would facilitate the programmatic handling of mismatches, and avoid the use of Any.

Have you tried building it?

No response

Self-service

  • I'd be willing to contribute this feature to Pact Python myself.
@JP-Ellis JP-Ellis added type:feature New feature difficulty:easy A simple task appropriate for newcomers to the codebase area:v3 Relating to the pact.v3 module labels Apr 2, 2024
@JP-Ellis JP-Ellis moved this to 📝 Backlog in Pact Python Apr 2, 2024
@JP-Ellis JP-Ellis self-assigned this Oct 8, 2024
@JP-Ellis JP-Ellis moved this from 📝 Backlog to 🛠️ In Progress in Pact Python Oct 8, 2024
@JP-Ellis JP-Ellis added the smartbear-supported This issue is supported by SmartBear label Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

🤖 Great news! We've labeled this issue as smartbear-supported and created a tracking ticket in PactFlow's Jira (PACT-2601). We'll keep work public and post updates here. Meanwhile, feel free to check out our docs. Thanks for your patience!

@github-project-automation github-project-automation bot moved this from 🛠️ In Progress to ✅ Completed in Pact Python Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase smartbear-supported This issue is supported by SmartBear type:feature New feature
Projects
Status: ✅ Completed
Development

Successfully merging a pull request may close this issue.

1 participant