Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch can't be applied due to $id$ expansion #111

Open
jpopelka opened this issue Oct 27, 2020 · 3 comments
Open

Patch can't be applied due to $id$ expansion #111

jpopelka opened this issue Oct 27, 2020 · 3 comments
Labels
kind/bug Something isn't working.

Comments

@jpopelka
Copy link
Member

When creating SRPM from a freeradius source-git repo one patch can't be applied

Patch #5 (freeradius-fixes-to-python3-module-since-v3.0.20.patch):
+ /usr/bin/patch --no-backup-if-mismatch -p1 --fuzz=0
patching file raddb/mods-available/python
patching file raddb/mods-available/python3
patching file src/include/conf.h
patching file src/main/modules.c
patching file src/modules/rlm_python3/configure
patching file src/modules/rlm_python3/configure.ac
patching file src/modules/rlm_python3/radiusd_test.py
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file src/modules/rlm_python3/radiusd_test.py.rej

The original dist-git patch (as well as the code in the freeradius tarball) contains expanded $Id$
$Id: 8582716ccbf340be00ce081ecf5ab078e93d1183 $.
In the conversion, this was "un-expanded" (to $Id$) from the base code (the very first commit) and the corresponding apply-patch commit in the source-git repo.
So when packit creates a patch to be included in SRPM it contains $Id$ which can't be applied to the tarball code any more.

@jpopelka jpopelka changed the title Patch can't be applied due to $id expansion Patch can't be applied due to $id$ expansion Oct 27, 2020
@TomasTomecek
Copy link
Member

I am trying to wrap my head around this. Can you see an easy solution here?

If not, I'd just turn it into a hard package and make it a single-commit repo.

@TomasTomecek TomasTomecek added the kind/bug Something isn't working. label Nov 2, 2020
@jpopelka
Copy link
Member Author

jpopelka commented Nov 2, 2020

I'd just turn it into a hard package and make it a single-commit repo.

which is what I did already: https://git.stg.centos.org/source-git/freeradius/commits/c8s-stream-3.0

@TomasTomecek
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants