Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests may depend on incorrect method to discriminate climatological variables #302

Open
rod-glover opened this issue Sep 25, 2023 · 0 comments

Comments

@rod-glover
Copy link
Contributor

The test (roughly rendered) cell_methods ~ '(within|over)' no longer gives correct results. Instead we must use (rendered as SQL)

ARRAY['climatology'::text] <@ variable_tags(meta_vars.*)

or its complement

ARRAY['observation'::text] <@ variable_tags(meta_vars.*)

Various fixes for this will be applied throughout the PDP stack, including in the databases:

In this repo, we may still be assuming the old method is still in use. See:

Fix these if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant