Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multisample handling #5

Open
ynanli opened this issue Nov 3, 2024 · 1 comment
Open

multisample handling #5

ynanli opened this issue Nov 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ynanli
Copy link

ynanli commented Nov 3, 2024

Hi,

Thanks for developing this nice software.

I am working with a SpatialExperiement object containing muiltiple samples with use.spatial = TRUE. I am curious how the function handles the data with multiple samples, as I noticed there are no arguments for sample id input. Does it mean that the default the 30 neighbors detected based on the spatial coordinates might come from different samples and thus would be incorrect in this case? (As the coordinates are in similar scales across samples in my dataset)

Many thanks!

concordexR/R/concordex.R

Lines 182 to 184 in c0ff58d

if (use.spatial) {
calculateConcordex(spatialCoords(x), labels=labels, ...)
} else {

@kayla-jackson kayla-jackson added the enhancement New feature or request label Nov 5, 2024
@kayla-jackson
Copy link
Collaborator

Hi @ynanli,

You are right that concordexR doesn't currently handle multiple samples. I'm working on adding this for the development version but will update the documentation to make this clear in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants