Crash when doing data propagation with a circuit in the network

[chateauferret]

Qt Nodes is fine with a circuit in the network if there is no data propagation through the nodes, but if there is, it causes an infinite loop and a stack overflow which leads to a crash.

I have some code for finding such loops somewhere (from an attempt of my own years ago), I can try and adapt that. Alternatively we can start propagating the data and remember the connection that triggered it, then send the user a snotty message if we end up back where we started. That way would only find circuits in a propagating network, of course.

[YashKarpe96]

i also am in the process of starting some work on this, maybe it requires a depth-first search (or breadth-first search approach to check before accepting any new connection

[qq978358810]

Connect to dfs using topology

[YashKarpe96]

Hey @qq978358810,

Could you provide a bit more detail on which internal classes or components you'd recommend starting with for the "connect to DFS using topology" approach? Any pointers or starting ground would be really helpful as we work on incorporating this.

Appreciate your input!