Refactored eveything and added Unit testing

Author: pablogsal

.travis.yml

@@ -0,0 +1,20 @@
+# Travis configuration file
+# http://docs.travis-ci.com/user/languages/python/
+language: python
+python:
+  - "3.5_with_system_site_packages"
+
+# Install numpy and scipy to avoid the painful compilation
+before_install:
+  - sudo apt-get update -qq
+  - sudo apt-get install -qq python-numpy python-scipy
+
+# Install fits_reduce...
+install:
+  - pip install .
+  - pip install coveralls
+# Run tests
+script:
+  - nosetests --with-coverage --cover-package=fits_reduce --cover-inclusive
+after_success:
+  - coveralls

README.md

@@ -178,11 +178,12 @@ class DijkstraHeap(list):
 
         while self and self[0].point in self.visited:
             heapq.heappop(self)
-
-        next_elem = heapq.heappop(self)
-        self.visited[next_elem.point] = next_elem.came_from
-        self.costs[next_elem.point] = next_elem.cost
-        return next_elem
+        
+        if self:
+            next_elem = heapq.heappop(self)
+            self.visited[next_elem.point] = next_elem.came_from
+            self.costs[next_elem.point] = next_elem.cost
+            return next_elem
 ```
 
 # So WHAT is this deep logic you talk about?

a_star/__init__.py

@@ -0,0 +1,3 @@
+__author__ = 'Pablo Galindo Salgado'
+
+from a_star import *

a_star/__pycache__/__init__.cpython-35.pyc

@@ -56,10 +56,11 @@ def pop(self):
         while self and self[0].point in self.visited:
             heapq.heappop(self)
 
-        next_elem = heapq.heappop(self)
-        self.visited[next_elem.point] = next_elem.came_from
-        self.costs[next_elem.point] = next_elem.cost
-        return next_elem
+        if self:
+            next_elem = heapq.heappop(self)
+            self.visited[next_elem.point] = next_elem.came_from
+            self.costs[next_elem.point] = next_elem.cost
+            return next_elem
 
 
 

a_star/__pycache__/a_star.cpython-35.pyc

@@ -0,0 +1,12 @@
+from distutils.core import setup
+
+setup(
+    name='a_star',
+    version='0.1',
+    packages=['a_star'],
+    url='https://github.com/pablogsal/a_star_algorithm/',
+    license='BSD',
+    author='Pablo Galindo Salgado',
+    author_email='[email protected]',
+    description='A pythonic implementation of the A* algorithm',
+)

a_star/__pycache__/test_a_star.cpython-35.pyc

@@ -0,0 +1,92 @@
+
+import unittest
+import a_star.a_star as a_star
+
+
+
+
+class DijkstraHeapTests(unittest.TestCase):
+
+    def test_sorted_unique(self):
+
+        test_data = [a_star.Node(x,x,None) for x in (5,7,3,2,5,3,5,7,2,1,3,1)]
+        sorted_unique = sorted(set(test_data))
+
+        # Prepare and insert elements in DijkstraHeap
+
+        frontier = a_star.DijkstraHeap()
+        for elem in test_data:
+            frontier.insert(elem)
+
+        # get out elements from the DijkstraHeap
+
+        result = []
+        while frontier:
+            elem = frontier.pop()
+            if elem:
+                result.append(elem)
+
+        self.assertTrue( result == sorted_unique  )
+
+    def test_delete_repeated(self):
+
+        test_data = [a_star.Node(x,x,None) for x in (1,1,1,1,1,1,1,1,1)]
+
+        # Prepare and insert elements in DijkstraHeap
+
+        frontier = a_star.DijkstraHeap()
+        for elem in test_data:
+            frontier.insert(elem)
+
+        # get out elements from the DijkstraHeap
+
+        result = []
+        while frontier:
+            elem = frontier.pop()
+            if elem:
+                result.append(elem)
+        self.assertTrue( result == [a_star.Node(1,1,None)]  )
+
+
+    def test_came_from(self):
+
+        test_data = [a_star.Node(x,x,x+1) for x in range(10)]
+
+        # Prepare and insert elements in DijkstraHeap
+
+        frontier = a_star.DijkstraHeap()
+        for elem in test_data:
+            frontier.insert(elem)
+
+        # Drain the DijkstraHeap
+
+        while frontier:
+            frontier.pop()
+
+        came_from_dic = { x:x+1 for x in range(10) }
+
+
+        self.assertTrue( came_from_dic == frontier.visited )
+
+    def test_came_from_unique(self):
+
+        test_data = [a_star.Node(x,x,x+1) for x in [0,1,2,3,2,4,1]]
+
+        # Prepare and insert elements in DijkstraHeap
+
+        frontier = a_star.DijkstraHeap()
+        for elem in test_data:
+            frontier.insert(elem)
+
+        # Drain the DijkstraHeap
+
+        while frontier:
+            frontier.pop()
+
+        came_from_dic = { x:x+1 for x in range(5) }
+
+
+        self.assertTrue( came_from_dic == frontier.visited )
+
+if __name__ == "__main__":
+    unittest.main()