Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests assume readonly is false; many fail if readonly is true #167

Open
usmanatron opened this issue Dec 12, 2016 · 0 comments

Comments

@usmanatron
Copy link
Contributor

To reproduce:

  • Get a fresh checkout of master
  • Edit the test config so that readonly is true (default in the sample file is false)
  • Run the tests via "make test"

We should still have all tests passing. Instead, a large number of them fail, as they're dependent on the readonly flag within the test config.

This isn't ideal. The best design in my mind is to define in each test what the expected value of readonly should be. This has the added gain of being able to add readonly specific tests (for example, when readonly is true, the "Add new URL" button should not be showing).

I'm keen to have a go with this, however I think it would be good to nail down what exactly we want to do. Is it reasonable for each test to override "readonly" as required? If a test should pass no matter the value of readonly, how should we manage that cleanly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants