-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from AWS S3 to Github hosted build artificats #544
Comments
The Setup for branches already exist, so maybe we can move forward with PR preview? |
@AdarshRawat1 I have just read the comment at the link in the first comment of this issue. If I understand correctly, the current state of this repo is that the CI is already committing PDF and HTML that is generated on every merge to main, and this is now visible on p4.org's specifications page. PDF and HTML are also being copied to a location on S3, and those are currently not used by p4.org, or as far as I know, by no one else. Are you suggesting that someone creates a PR that stops copying the PDF and HTML to S3? Or are you suggesting some other change should be made? |
As mentioned by @fruffy sir, in this comment . I'm suggesting to add a PR preview system similar to what we have in P4C. Where reviewer can view the changes made by the PR as Live preview without actually building the website locally. |
That would be one of the outcomes, the other outcome is that we have a preview per PR for the P4Runtime spec PDF and markdown. |
We discussed this briefly at the P4 API WG meeting and there is broad consensus that this is a good direction forward. |
Context of the discussion: #539 (comment)
The text was updated successfully, but these errors were encountered: