Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe rework subcommands for silo- and fleet-scoped timeseries #963

Open
david-crespo opened this issue Dec 29, 2024 · 0 comments
Open

Maybe rework subcommands for silo- and fleet-scoped timeseries #963

david-crespo opened this issue Dec 29, 2024 · 0 comments

Comments

@david-crespo
Copy link
Contributor

david-crespo commented Dec 29, 2024

See fc95ef8

I noticed this while bumping the CLI in the v12 docs PR: the timeseries command hierarchy is a little confusing. It's all under experimental (which makes it less bad and we can probably punt for a while) but we're reproducing the system/developer distinction inside of experimental.

image

I think it's tolerable, but it's worth mulling over. Presumably these commands will eventually stop being experimental. In that case we have oxide timeseries (silo-scoped) and oxide system timeseries (fleet-scoped). That matches the API routes, but it's not really how we handle fleet-scoped stuff in the CLI. For example, silo stuff is all admin-oriented but it lives under oxide silo.

Image

I'm thinking oxide timeseries is the top-level thing, and then we distinguish system vs. not inside there? It's still a little dicey, e.g., is it oxide timeseries system query vs. oxide timeseries query?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant