Move nexus::internal_api::params into nexus-types

Author: jgallagher

nexus/src/internal_api/mod.rs

@@ -3,4 +3,5 @@
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
 pub mod http_entrypoints;
-pub mod params;
+
+pub use nexus_types::internal_api::params;

nexus/types/src/external_api/shared.rs

@@ -272,15 +272,11 @@ pub enum IpKind {
 
 #[cfg(test)]
 mod test {
-    use super::IdentityType;
     use super::Policy;
     use super::MAX_ROLE_ASSIGNMENTS_PER_RESOURCE;
-    use crate::external_api::shared;
     use crate::external_api::shared::IpRange;
     use crate::external_api::shared::Ipv4Range;
     use crate::external_api::shared::Ipv6Range;
-    use anyhow::anyhow;
-    use omicron_common::api::external::Error;
     use serde::Deserialize;
     use std::net::Ipv4Addr;
     use std::net::Ipv6Addr;

nexus/types/src/identity.rs

@@ -31,7 +31,7 @@ pub trait Resource {
     fn identity(&self) -> IdentityMetadata {
         IdentityMetadata {
             id: self.id(),
-            name: self.name().clone().into(),
+            name: self.name().clone(),
             description: self.description().to_string(),
             time_created: self.time_created(),
             time_modified: self.time_modified(),

nexus/types/src/internal_api/mod.rs

@@ -0,0 +1,5 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
+pub mod params;

nexus/src/internal_api/params.rs renamed to nexus/types/src/internal_api/params.rs

@@ -4,3 +4,4 @@
 
 pub mod external_api;
 pub mod identity;
+pub mod internal_api;