New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 0.15.1 typescript-eslint(consistent-type-imports) #7879

Closed

Brooooooklyn opened this issue Dec 14, 2024 · 1 comment · Fixed by #7923 or #8134

Assignees

Labels

A-linter A-semantic C-bug

Member

Brooooooklyn commented Dec 14, 2024

A number of imports are considered type-only imports, but they are actually used as values.

See https://github.com/toeverything/AFFiNE/actions/runs/12317223993/job/34379255779?pr=9161

Brooooooklyn added the C-bug label

Boshen assigned Dunqing

Dunqing added A-linter A-semantic labels

Dunqing closed this as completed

Dunqing linked a pull request

that will close this issue

fix(semantic): reset references flags when resolved #7923

Merged

Member Author

Brooooooklyn commented Dec 26, 2024

Still have a false positive error in 0.15.3: https://github.com/toeverything/AFFiNE/runs/34882599366

Brooooooklyn reopened this

camc314 mentioned this issue

fix(semantic): reference flags not correctly resolved when after an export stmt #8134

Merged

Boshen pushed a commit that referenced this issue


          fix(semantic): reference flags not correctly resolved when after an e…

79af100

…xport stmt (#8134)

fixes #7879 (comment)

TLDR is curently here:

https://github.com/oxc-project/oxc/blob/cdd121bfa4a66d5b2cf72a444f35e82daf81d11e/crates/oxc_semantic/src/builder.rs#L2130-L2135

`self.current_reference_flags.is_empty()` is not empty, which causes the current ref flags to be used (this is incorrect, we should be using a fresh version of reference flags). Buy setting ref flags to `None` on exit export node, this issue is avoided

`export` **BEFORE** the reference ( incorrect reference flags)

https://playground.oxc.rs/#eNpVjjuOwzAMRK8isElj7A/YxtttkVOkkR3aECCJBskkdgzdPZISG0ilGc3DcFbooQUXJmI1q/m3bJIZmII5fHx2lg9/p4hzTXWZsCL3N+RekB3qvRUxRyKDs2I8S61cEzRA0K7Al1geWaLaGVrlCzbgXdRNS08T7mYJHfnNKdsoA3GAdrBeMDUwWRbk3Jh1adn0jtYPUMsj5hOA8vP1/QuZ6OmMI5Yx2QQX3eCebLBx9K8FlYvK5I+ebiW9InckOX4uSOkBCrdvkw==

`export` **AFTER** the reference ( correct reference flags)

https://playground.oxc.rs/#eNpVjj2uwjAQhK9ibZMmen/Sa0JHwSlonLCJLNm70a6BhMh3xzEEQeUZz6fZWaCDBlwYWaJZzN6KSaYXDqb6+m6tVLsjHQmnknfeqpoDs8EpIp208Et6Q+I8Yum5ffTcqh3UwNAsIGdaH50p2gmaKGeswTuKm9aOR3yZObTsNxfFkvYsAZreesVUw2hFUXJj1mvLpl9o+YBoZcB8AlD/fn7/IRMdn3DAdUw2wZHr3YMNlgb/XFA4isL+4Pm6pheUljXHjwUp3QEtmnBd

this PR fixes this issue by resetting the reference flags after exising an export stmt

camc314 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment