Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxlint configuration file setting #84

Open
nrayburn-tech opened this issue Oct 26, 2024 · 4 comments
Open

Oxlint configuration file setting #84

nrayburn-tech opened this issue Oct 26, 2024 · 4 comments

Comments

@nrayburn-tech
Copy link
Contributor

The VS Code plugin currently only supports specifying a single configuration file. However, the CLI supports nested configuration files. The IntelliJ Eslint plugin supports various configuration options.

What should be supported by the Oxc IntelliJ plugin?

  • Support for specifying a single configuration file is relatively straightforward to implement. However, it comes with the problem that nested configs won’t work and you may have different results between the CLI and the plugin.
  • Support for nested configs and automatic resolution is more difficult, but probably a better user experience. May require language server enhancements to benefit VS Code and IntelliJ plugins.
@nrayburn-tech
Copy link
Contributor Author

@DonIsaac not sure if you have any thoughts on this. I assume we would want VS Code and IntelliJ plugins to have similar behavior where possible.

I think that if the language server was enhanced to automatically resolve the configuration file for a given input file, then we would be able to have consistent behavior in both plugins and improve the user experience.

https://eslint.org/docs/latest/use/configure/configuration-files#configuration-file-resolution is what I’m referring to if it wasn’t clear. Just that sort of behavior in the language server when publishing diagnostics.

@DonIsaac
Copy link

We don't support nested configs yet. I'm working on overrides this week and will be tackling that next. Afterwards, I think nested configs will get handled by the language server and not the editor plugin. Still need to hammer out file naming conventions.

@nrayburn-tech
Copy link
Contributor Author

Sounds good to me. In the meantime, I might just match the VS Code functionality with a path to a single config to have something a bit more releasable for the plugin. Then it can be enhanced later.

@nrayburn-tech
Copy link
Contributor Author

Per #54 (comment), just going to wait for the nested config support. The first IntelliJ plugin release will hopefully come sometime shortly after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants