-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support configuring the "run" option for the language server #62
Comments
IntelliJ LSP doesn't currently support the
|
JetBrains is adding support in 2024.3.1. This brings up the question of what JetBrains IDE versions this plugin should target for support. Maybe just the latest stable? |
@Boshen @IWANABETHATGUY (or anybody else) have any thoughts on what versions of JetBrains IDEs to try and support? Given my previous comment about the LSP APIs being experimental, I think it only makes sense to support the latest version for now. |
I am not familiar with JetBrains actually, can you have a look at the biome? Maybe same as biome should be enough. |
A lot of information below, tried to separate it into reasonable chunks. Biome and JetBrains StatisticsBiome is currently targeting the latest release. 2024.3.* (or 243.* in the other version format in use some places). https://plugins.jetbrains.com/docs/marketplace/product-versions-in-use-statistics.html contains some 2023 statistics from JetBrains on which versions were in use at the time. It indicates targeting the current and prior 2 major releases should cover 80% of the JetBrains users. Difficulty with Multiple VersionsThe difficulty with targeting multiple versions is the major versions may have API changes, especially with the LSP API being experimental. It is possible to release a different plugin version targeting different JetBrains versions, but it is not trivial. For example, we might have to maintain multiple branches corresponding to the different releases that compatibility is desired for. An explanation of an example branching strategy that could be used to support multiple IDE versions.
This would mean maintaining changes in each branch. Depending on the significance of the API changes, the effort here could vary greatly. SuggestionTarget latest for now as we have a need to change. As the LSP API stabilizes and the plugin stops adding new features, expand the supported versions to cover at least the last 3 major releases. |
Yeah, that should make sense, let's apply your suggestion, and wait user's feedback |
The text was updated successfully, but these errors were encountered: