Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericEvent stopPropagation() method is deprecated #278

Open
phil-davis opened this issue Feb 6, 2020 · 0 comments
Open

GenericEvent stopPropagation() method is deprecated #278

phil-davis opened this issue Feb 6, 2020 · 0 comments

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Feb 6, 2020

in Symfony4

[debug] Running '/usr/bin/php7.3' '-n' '-c' '/tmp/SQ8qlM' 'vendor-bin/phan/vendor/bin/phan' '--config-file' '.phan/config.php' '--require-config-exists'
lib/HooksHandler.php:141 PhanDeprecatedFunction Call to deprecated function \Symfony\Component\EventDispatcher\GenericEvent::stopPropagation() defined at ../../lib/composer/symfony/event-dispatcher/Event.php:34
[debug] Restarted process exited 1
Makefile:134: recipe for target 'test-php-phan' failed
make: *** [test-php-phan] Error 1

See lib/HooksHandler.php generatePassword()

	public function generatePassword(GenericEvent $event) {
		$this->fixDI();
		$event['password'] = $this->engine->generatePassword();
		/* ToDo: issue 278 - deprecated since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead */
		/* @phan-suppress-next-line PhanDeprecatedFunction */
		$event->stopPropagation();
	}

The phan message has been suppressed.

This will need to be fixed "some time" before Symfony5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant