Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for spaces, consecutive/identical chars, max length #16

Open
BitMEXResearch opened this issue Jun 19, 2018 · 4 comments
Open

Check for spaces, consecutive/identical chars, max length #16

BitMEXResearch opened this issue Jun 19, 2018 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@BitMEXResearch
Copy link

Hello Team,

You are validating the 4 things right now but missing some important policies. Here are some policy which will improve the security of your webapp.

(01) Set the maximum character length for a password as a best practice e.g. thirty characters max.
(02) No spaces.
(03) No consecutive keyboard characters.
(04) No consecutive identical characters.

Please find this article for reference: https://eits.uga.edu/access_and_security/infosec/pols_regs/policies/passwords/password_standard/

Hope to hear back some positive news from your side.

Regards & Thanks
Mohammed Israil

@karakayasemi
Copy link
Contributor

Just an information, this topic is continuation of owncloud-archive/security#34 . (03) and (04) was considered as an enhancement in here:
owncloud-archive/security#34 (comment) .

@karakayasemi karakayasemi added the enhancement New feature or request label Jun 19, 2018
@BitMEXResearch
Copy link
Author

Hello,

Did you test the 02 feature? Because I have gone through the source code but didn't find any validation for that. Please take a look into that as well.

Regards & Thanks,
Mohammed Iserail

@phil-davis
Copy link
Contributor

phil-davis commented Jun 19, 2018

I just checked in 10.09RC1. The following passwords work:
a<space>b
<space>a
a<space>
So the user can embed spaces anywhere in the password.
The user has to enter the spaces correctly to login, so they are being used as part of the input to generating the stored password hash.

I can understand why that Uni of Georgia policy document would say not to use tab in a password - that would just be really difficult to actually input on a login page! But I am not sure why a user should not use the space character in their password?

@BitMEXResearch
Copy link
Author

Hello @phil-davis

Thanks for the information.

The simple answer for this is it is a bad password policy. You are using UTF-8 and I don't think this would be a problem but the point over here is to limit the password length as well so that somebody doesn't soak up 1MB of bandwidth (and the corresponding CPU time to hash the input) every time they login.

Hope you'll understand the technicality of this.

Regards & Thanks,
Mohammed Israil

@PVince81 PVince81 added this to the backlog milestone Jul 16, 2018
@PVince81 PVince81 changed the title Password Policy Enhancement Check for spaces, consecutive/identical chars, max length Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants