-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chunking from capabilities #203
Comments
I'd like to have a try at this. @butonic should the chunking code be removed completely or kept for later ? |
I've grepped through reva code and it seems the chunking can be enabled through the config file. Proposed change:
|
as far as I saw there is some chunking v1 code in ocdav in reva, so it does "support" it but I guess it's broken in some way here's a PR to remove the capability entry in reva: cs3org/reva#678 |
as far as we saw, chunking v1 (the old one which uses PUT with special file names) is already disabled in ocis-reva as the "bigfilechunking" capability value is set to false we discovered that the desktop client is not reading that value, raised here: owncloud/client#7849 |
removed chunking v2 advertising from ocis-reva here: owncloud/ocis-reva#145 I consider this task done from my side. |
@PVince81 steps to test-drive this with a client? |
best is to wait for the release of ocis-reva and update of ocis dependencies to point at the new version, which will make the setup easier. (cc @micbar) setting up basically means following the instructions in the README of the OCIS repo: https://github.com/owncloud/ocis#development |
apparently the change in ocis-reva was not enough, also need the change in reva: cs3org/reva#678 |
Tested with:
oCIS as of today doesn't support chunking (#195), and there's no short term plan for full implementation.
Please stop announcement of chunking capabilities. (see comments #194 (comment) & #194 (comment))
Calling capabilities
Request:
Click to expand response
Workaround
The text was updated successfully, but these errors were encountered: