Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different remaining space base shown in space list and sidebar #10268

Open
rhafer opened this issue Sep 30, 2024 · 8 comments
Open

Different remaining space base shown in space list and sidebar #10268

rhafer opened this issue Sep 30, 2024 · 8 comments
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker

Comments

@rhafer
Copy link
Contributor

rhafer commented Sep 30, 2024

There is also a bit of discrepancy in the UI regarding the remaining space.

In the space list (when using the table view instead of the grid view) we see the remaining diskspace listed as the remaining quota which is at least misleading, when quota > remaining diskspace.
image

The the details view on the sidebar we the the quota usage calcuated based on the quota and actual space usage.
image

This is at least confusing. Also I am wondering if we really should expose the remaining diskspace at all, independent of which blobstore is being used. At least we should make a clear differentiation between how much quota is used and the amount of remaining diskspace.

Originally posted by @rhafer in #9245 (comment)

@rhafer
Copy link
Contributor Author

rhafer commented Sep 30, 2024

@JammingBen

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Sep 30, 2024

@JammingBen @kulmann we have a lot of "space" (width) in the "remaining quota" cell, I think it could be quite useful to show the full bloated information, like in the details panel there and rename the column to "Quota":

image

What do you think?

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Oct 3, 2024

I tested it, unfortunately, it's getting too messy in the UI

image

But in the sidebar, I added the remaining quota to the quota information, which I think can be quite useful.

image

Back to topic

Currently, I can't spot an inconsistency between the list and the right sidebar, but the API gives us strange results:

Total quota: 2gb
Used: 47kb
Remaining: 1.4gb

image

So, I don't understand which issue we are trying to solve here, does not look like a front end/web issue.

cc @tbsbdr @kulmann @rhafer

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Oct 3, 2024

It's getting even stranger, without any actions to that space, but just some reloads, the remaining quota is decreasing:

image

All of this is coming from the API, there ain't any calculations we do here

@kulmann
Copy link
Member

kulmann commented Oct 4, 2024

It's getting even stranger, without any actions to that space, but just some reloads, the remaining quota is decreasing:
All of this is coming from the API, there ain't any calculations we do here

@rhafer I think this is where all the confusion comes from. There are 3 fields in the quota information coming in via API (total, used and remaining quota). Web doesn't do any calculations on its own, just displaying values. I think we should change the backend to return the remaining quota without incorporating the remaining disk space. Of course the remaining disk needs to be incorporated when trying to persist to the storage. But for the user it's just confusing to see any situation where total - used != remaining.

@AlexAndBear AlexAndBear self-assigned this Oct 7, 2024
@rhafer
Copy link
Contributor Author

rhafer commented Oct 8, 2024

@rhafer I think this is where all the confusion comes from. There are 3 fields in the quota information coming in via API (total, used and remaining quota). Web doesn't do any calculations on its own, just displaying values.

I know. (I though that was clear from the report). But IMO the confusion is coming from the fact the the UI is showing remaining disk space value in once place (space list) and the quota usage in the other (sidebar).

I think we should change the backend to return the remaining quota without incorporating the remaining disk space. Of course the remaining disk needs to be incorporated when trying to persist to the storage. But for the user it's just confusing to see any situation where total - used != remaining.

I think I agree with that. But I wasn't able to convince others (I am looking at you @butonic 😄 ) that "remaining" shouldn't be calculated based on the free diskspace but based on the quota.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Oct 8, 2024

It's always @butonic 😂😂😂

@rhafer if you expand the window you will see, that the list will show all the quota related values.
But we voted that the remaining quota is the most relevant value, so you even see it when you have a smaller window.

image

I tried to show the remaining quota as well in the right side bar owncloud/web#11722

image

but @kulmann says it's too crowded, which might be true

@AlexAndBear
Copy link
Contributor

DIscuessed this with several people.
We should show the actual remaining quota instead of the free disk space (if lower than quota).
So moving this back to OCIS

@AlexAndBear AlexAndBear removed their assignment Oct 9, 2024
@AlexAndBear AlexAndBear transferred this issue from owncloud/web Oct 9, 2024
@micbar micbar added the Priority:p2-high Escalation, on top of current planning, release blocker label Oct 21, 2024
@kobergj kobergj self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker
Projects
Status: In progress
Development

No branches or pull requests

5 participants