Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting #46

Open
PVince81 opened this issue Mar 16, 2017 · 3 comments
Open

Sorting #46

PVince81 opened this issue Mar 16, 2017 · 3 comments

Comments

@PVince81
Copy link
Contributor

Sorting is currently wrong and also done on the client side.

Once we add pagination, client-side sorting will not be possible any more so it needs to be done on the backend side.

  • Groups list sort:
    • first: role (admin, then member)
    • second: group display name
  • Members list sort:
    • first: role (admin, then member)
    • second: user display name (will become a headache until we have the account table to join on)

@pmaier1 FYI, I think these sort defaults make sense. I do not plan to make alternative sorts with clickable columns in this first version.

cc @felixheidecke

@PVince81 PVince81 added this to the 0.1.1 milestone Mar 16, 2017
@PVince81 PVince81 self-assigned this Mar 16, 2017
@PVince81
Copy link
Contributor Author

Additionally: seems that backbone doesn't insert-sort after adding an item, needs to investigate.

@PVince81 PVince81 modified the milestones: 0.1.2, 0.1.1 Mar 27, 2017
@PVince81
Copy link
Contributor Author

Sorting by displayname becomes more complex, that is unless we sort on PHP level...
Sorting on DB level would be nicer but we might want natural sort which is only possible on PHP or JS level...

@pmaier1
Copy link
Contributor

pmaier1 commented Apr 21, 2017

I think these sort defaults make sense.

Yes, looks good to me. Regarding your other comments I'm not quite sure if I get you right. If important, let's have a quick call.

Edit: Clickable column sorting is not important for now. Can be added later if not much effort.

@PVince81 PVince81 modified the milestones: 0.3.0, 0.1.2 Apr 21, 2017
@PVince81 PVince81 modified the milestones: triage, 0.3.0 Jun 26, 2017
@PVince81 PVince81 removed their assignment Jun 26, 2017
@PVince81 PVince81 modified the milestones: triage, maybe some day May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants