Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to variables.env (OVERLEAF_NAV_TITLE) not reflected #295

Open
morfismo opened this issue Oct 11, 2024 · 1 comment
Open

changes to variables.env (OVERLEAF_NAV_TITLE) not reflected #295

morfismo opened this issue Oct 11, 2024 · 1 comment

Comments

@morfismo
Copy link

morfismo commented Oct 11, 2024

Steps to Reproduce

  1. Setting OVERLEAF_NAV_TITLE="Another title"
    2.Stopping/starting the toolkit with bin/stop ; bin/start

Expected Behaviour

Header should change to "Another title"

Observed Behaviour

Header remains initaally set vale

Context

Makes it unable to change header/logo, etc/ as instructed on https://github.com/overleaf/overleaf/wiki/Configuring-Headers,-Footers-&-Logo

Technical Info

  • URL: any url
  • Browser Name and version: any browser / Overleaf 5.1.1.
  • Operating System and version (desktop or mobile): windos / linux
  • Signed in as: adminaccount but also without logging in
  • Project and/or file: variables.env

Analysis

Changing option on variables.env has no effect.
After initial installation, setting
OVERLEAF_NAV_TITLE="Another title"

stopping and restarting with bin/up ; bin/start

will keep the old "My Overleaef Instance" title.
The new variables aren't picked up (the only way to get them picked is setting them up BEFORE initial bin/up)

bin/doctor shows file present but no value picked up from the file

====== Configuration ======
- config/version
    - status: present
    - version: 5.1.1
- config/overleaf.rc
    - status: present
    - values
        - OVERLEAF_DATA_PATH: data/overleaf
        - OVERLEAF_LOG_PATH: not set, keeping logs in container
        - SERVER_PRO: false
        - SIBLING_CONTAINERS_ENABLED: false
        - OVERLEAF_LISTEN_IP: 0.0.0.0
        - OVERLEAF_PORT: 31416
        - MONGO_ENABLED: true
        - MONGO_IMAGE: mongo
        - MONGO_VERSION: 6.0
        - MONGO_DATA_PATH: data/mongo
        - REDIS_ENABLED: true
        - REDIS_IMAGE: redis:6.2
        - REDIS_AOF_PERSISTENCE: true
        - REDIS_DATA_PATH: data/redis
        - NGINX_ENABLED: false
        - NGINX_CONFIG_PATH: config/nginx/nginx.conf
        - TLS_PRIVATE_KEY_PATH: config/nginx/certs/overleaf_key.pem
        - TLS_CERTIFICATE_PATH: config/nginx/certs/overleaf_certificate.pem
        - NGINX_HTTP_LISTEN_IP: 127.0.1.1
        - NGINX_HTTP_PORT: 80
        - NGINX_TLS_LISTEN_IP: 127.0.1.1
        - TLS_PORT: 443
        - GIT_BRIDGE_ENABLED: false
- config/variables.env
    - status: present
    - values
        - SHARELATEX_FILESTORE_BACKEND: fs
        - SHARELATEX_HISTORY_BACKEND: fs
        - OVERLEAF_FILESTORE_BACKEND: fs
        - OVERLEAF_HISTORY_BACKEND: fs
====== Warnings ======
! Detected SIBLING_CONTAINERS_ENABLED=false. When not using Sibling containers, users have full read and write access to the 'sharelatex' container resources (filesystem, network, environment variables) when running LaTeX comp
iles. Only use this mode in environments where all users are trusted and no isolation of users is required.
====== End ======

But config/variables.env has:

## Nginx
# NGINX_WORKER_PROCESSES=4
# NGINX_WORKER_CONNECTIONS=768

## Set for TLS via nginx-proxy
# OVERLEAF_BEHIND_PROXY=true
# OVERLEAF_SECURE_COOKIE=true

# OVERLEAF_SITE_URL=http://tex.ommyuc.org
OVERLEAF_NAV_TITLE="Another title"
# OVERLEAF_HEADER_IMAGE_URL=http://somewhere.com/mylogo.png
OVERLEAF_ADMIN_EMAIL="[email protected]"

# OVERLEAF_LEFT_FOOTER='[{"text": "Contact your support team", "url": "mailto:[email protected]"}]'
# OVERLEAF_RIGHT_FOOTER='[{"text": "Hello, I am on the Right"}]'

# [email protected]
@QAGovaerts
Copy link

I had the same problem. Turns out that with bin/stop the containers are not removed so you just restart the same containers with bin/start. In order for the changes in overleaf.rc and variables.env to have any effect you have to recreate the containers with:

bin/docker-compose down
bin/docker-compose up -d

The first command stops and removes the running containers. The second one recreates them with the new configuration (you could also run bin/up for this but then they are not detached).

Hope this helps you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants