Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jhony/python 3 12 #36

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Jhony/python 3 12 #36

merged 2 commits into from
Apr 29, 2024

Conversation

jfavellar90
Copy link
Collaborator

It aims to close #33

@jfavellar90 jfavellar90 changed the base branch from master to nightly April 18, 2024 12:30
@jfavellar90
Copy link
Collaborator Author

I already tested the new Notes image in a nightly environment with success.

Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. I will try to verify the image build by tomorrow and give 👍🏽 on PR. Thanks

Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image is building as expected, notes feature appears to be working.

@DawoudSheraz
Copy link
Contributor

@jfavellar90 Hi, this should be good to merge. Régis is OOO and won't be able to add his review. Since the build is working as expected, this is good to go.Thanks

@jfavellar90 jfavellar90 merged commit 20ec2c8 into nightly Apr 29, 2024
2 checks passed
@jfavellar90 jfavellar90 deleted the Jhony/python_3_12 branch April 29, 2024 16:28
regisb added a commit that referenced this pull request Jun 20, 2024
* feat: adding python 3.12 support (#36)

* feat: adding first version of Dockerfile Python3.12 compatible

* ci: add python 3.12 checks

* feat: upgrade to redwood
@DawoudSheraz DawoudSheraz mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

tutor-notes codebase Python 3.12 upgrade
2 participants