-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement promiseHooks
from node:v8
#6136
Comments
node:v8
We'd have to think about if this is worth implementing, since it could have a performance impact. (it tracks all promises) However, even if it is feasible, it's not a high priority. |
node:v8
promiseHooks
from node:v8
@Electroid Is there any update on this? |
Sadly the Temporal Typescript SDK does not work without createHook 😩 I'd love to have it at least as an opt-in if the performance impact is big. Ping @lorensr |
What's the status on this? Is an implementation of |
I'm the author of the code you linked in the Temporal TypeScript SDK. |
@bergundy if Promise Hooks are optional is there a way to disable them so that we can use Bun. There is a linked issue on the Temporal project. |
Can bun simply keep silent about this instead of throw an error, if there is no plan to implement this in short time. Just like what deno did in this PR: https://github.com/denoland/deno/pull/25979/files maybe just use Lines 101 to 117 in 25fcbed
or just simply remove the promiseHooks object |
#14485 seems like the way to go. If it ends up not getting merged, we may be able to do something on the Temporal SDK side, it should be easy to edit the SDK files post install to remove the use of promise hooks and confirm. |
What is the problem this feature would solve?
When trying to use temporal sdk (https://github.com/temporalio/sdk-typescript), getting error
Its used right here:
https://github.com/temporalio/sdk-typescript/blob/3ce098be042e86d26ea5b433508a480503cb09b2/packages/worker/src/workflow/vm-shared.ts#L198
What is the feature you are proposing to solve the problem?
Implement createHook.
What alternatives have you considered?
Ask temporal to not use createHook, but probably out of reach since its needed to isolate the VM scope.
The text was updated successfully, but these errors were encountered: