Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more details in readme / disclaimer for managed workflow #2

Closed
castdrian opened this issue Feb 2, 2023 · 4 comments
Closed

more details in readme / disclaimer for managed workflow #2

castdrian opened this issue Feb 2, 2023 · 4 comments

Comments

@castdrian
Copy link

for android this requires the manifest to be edited and expo doesn't let you do that very easily, you have to make a patch that runs on compiletime, ideally the readme should mention that this is required for the managed workflow or perhaps maybe even provide an example patch

@outsung
Copy link
Owner

outsung commented Feb 2, 2023

this library assumes to use eas build.
as shown in readme, add a plugin to app.json
and run expo prebuild to automatically set up Android Manifest.

@outsung
Copy link
Owner

outsung commented Feb 2, 2023

and if you develop with expo-dev-client
rebuild and run with expo start --dev-client works fine

@castdrian
Copy link
Author

yeah it does work but uses the legacy icon instead of the dynamic icon which makes it look really bad
qemu-system-x86_64_X6t3datx5H

@outsung
Copy link
Owner

outsung commented Feb 3, 2023

hum... ok let me check with new issue #3

@outsung outsung closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants